This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ilya Verbin <iverbin at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Andrey Turetskiy <andrey dot turetskiy at gmail dot com>
- Date: Wed, 12 Nov 2014 10:07:47 +0100
- Subject: Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing
- Authentication-results: sourceware.org; auth=none
- References: <20141021171323 dot GA47586 at msticlxl57 dot ims dot intel dot com> <20141030114001 dot GA34120 at msticlxl57 dot ims dot intel dot com> <20141106175540 dot GN5026 at tucnak dot redhat dot com> <20141110143430 dot GB50497 at msticlxl57 dot ims dot intel dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Nov 10, 2014 at 05:34:30PM +0300, Ilya Verbin wrote:
> > I don't like this, that is too fragile. If automake is changed, we'll
> > forget to update this.
> > If all you are about are the 3 additional variables, can't you instead
> > put them into env vars and query them in the tcl code using getenv?
> > Or append them into AM_RUNTESTFLAGS ?
> > AM_RUNTESTFLAGS += @something@
>
> Done, I put them into env vars.
Thanks.
> > > + lappend ALWAYS_CFLAGS "additional_flags=${offload_additional_options}"
> > > }
> >
> > Perhaps add this only if offload_additional_options is non-empty?
>
> Done.
Ok for trunk.
Jakub