This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH diagnostics/fortran] dynamically generate locations from offset + handle %C (try 2)
- From: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org List" <fortran at gcc dot gnu dot org>, Dodji Seketeli <dodji at redhat dot com>, Tobias Burnus <burnus at net-b dot de>, Tom Tromey <tromey at redhat dot com>
- Date: Tue, 11 Nov 2014 23:54:32 +0100
- Subject: Re: [PATCH diagnostics/fortran] dynamically generate locations from offset + handle %C (try 2)
- Authentication-results: sourceware.org; auth=none
- References: <CAESRpQB_y0GGpmVQpgH3ZcwF6DMzNxGdXXOef_6J51g6hxooYg at mail dot gmail dot com> <54623509 dot 7080408 at redhat dot com>
On 11 November 2014 17:10, Jason Merrill <jason@redhat.com> wrote:
> On 10/31/2014 10:01 PM, Manuel López-Ibáñez wrote:
>>
>> + sense. So let's live the location intact in that case. */
>
>
> s/live/leave/
>
>> + /* If MAP is not the last line map of its set, then the new location
>> + (loc + offset) should be less than the first location encoded by
>> + the next line map of the set. */
>
>
>> + linemap_assert (MAP_START_LOCATION (&map[1]) < loc + offset);
>
>
> This comparison looks backwards from the comment.
Copy-paste error. In any case, this check is currently pointless,
since Fortran only has one map per set. I fixed this and tested
Fortran again just in case. No failures, thus I committed the whole
thing as http://gcc.gnu.org/r217383.
Cheers,
Manuel.