This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 11 Nov 2014 18:09:41 +0000
- Subject: Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library
- Authentication-results: sourceware.org; auth=none
- References: <20141111153449 dot GB52080 at msticlxl57 dot ims dot intel dot com> <alpine dot DEB dot 2 dot 10 dot 1411111754330 dot 26374 at digraph dot polyomino dot org dot uk>
On Tue, 11 Nov 2014, Joseph Myers wrote:
> You have lots of static writable variables. Are you sure all those
> variables are handled in a thread-safe way (e.g. only modified before any
> threads start)?
Another general multi-thread issue for libraries: files should be opened
with O_CLOEXEC (that's the "e" flag to fopen when using glibc) unless you
have a clear reason not to do so.
--
Joseph S. Myers
joseph@codesourcery.com