This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jonathan Wakely <jwakely at redhat dot com>, Joel Sherrill <joel dot sherrill at oarcorp dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
Date: Mon, 10 Nov 2014 20:03:18 +0100
Subject: Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)
Authentication-results: sourceware.org; auth=none
References: <1415633767-18196-1-git-send-email-joel dot sherrill at oarcorp dot com> <5460FD76 dot 7080806 at oarcorp dot com> <20141110183443 dot GD5191 at redhat dot com>

Hi,

On 11/10/2014 07:34 PM, Jonathan Wakely wrote:

On 10/11/14 12:01 -0600, Joel Sherrill wrote:

cc'ing since both lists should be included.

The m32c has 24-bit pointers and 16-bit size_t. This changes
pushing a pointer through a size_t to pushing it through a
uintptr_t.


I'm OK with this change if Paolo is.

No problem with the experiment (frankly, I'm not at all sure that thetargets not providing <stdint.h> are *that* much uncommon than thetarget which we are fixing with the patch), but please add a commentabout <stdint.h> in the code, then if bootstrap actually breaks theissue is clear...


Paolo.

Follow-Ups:
- Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)
  - From: Joel Sherrill
- Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)
  - From: Joel Sherrill

References:
- [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)
  - From: Joel Sherrill
- Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)
  - From: Joel Sherrill
- Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]