This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PATCH]Partially fix PR61529, bound basic block frequency
- From: Teresa Johnson <tejohnson at google dot com>
- To: Renlin Li <renlin dot li at arm dot com>
- Cc: Jeff Law <law at redhat dot com>, Dehao Chen <dehao at google dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, "su at cs dot ucdavis dot edu" <su at cs dot ucdavis dot edu>
- Date: Mon, 10 Nov 2014 09:00:14 -0800
- Subject: Re: [PING][PATCH]Partially fix PR61529, bound basic block frequency
- Authentication-results: sourceware.org; auth=none
- References: <5450B2C0 dot 6040807 at arm dot com> <CAAe5K+Uv4i3ZcBbK66ZdyyWZUC-7yongg8ZQeHkWNCugJ664cg at mail dot gmail dot com> <54579F5B dot 9070700 at arm dot com> <54594C46 dot 6080704 at redhat dot com> <545B8F35 dot 9070603 at arm dot com> <CAAe5K+XEY+trRiE4dpNjr7-o=Bnky_OAX8w2+Qwaqv0jVbSLUw at mail dot gmail dot com> <545BB5B5 dot 90008 at arm dot com> <CAAe5K+VQUv7oK0xj8+L-nzZwjj2DPWLyuw1H9xVcN79YObnvXA at mail dot gmail dot com> <545BB8F5 dot 8070500 at arm dot com> <5460EEE7 dot 1090701 at arm dot com>
Hi Renlin,
Looks like Jeff already approved it:
>Can you add a testcase please? With a testcase, this patch is OK for the trunk.
Teresa
On Mon, Nov 10, 2014 at 8:59 AM, Renlin Li <renlin.li@arm.com> wrote:
> On 06/11/14 18:07, Renlin Li wrote:
>>
>> On 06/11/14 17:59, Teresa Johnson wrote:
>>>
>>> Thanks for fixing the test case. Can you also add the comment I
>>> suggested to the source change?
>>>
>>>> Please add a comment that this is needed due to insane incoming
>>>> frequencies.
>>>>
>>
>> Sorry, I mistakenly add it to the ChangeLog. Should be correct now.
>>
>>
>> x86_64-unknown-linux-gnu bootstrap and regression test have been done, no
>> new issue.
>> aarch64-none-elf toolchain has been test on the model. No new regression.
>>
>> gcc/ChangeLog:
>>
>> 2014-11-06 Renlin Li <Renlin.Li@arm.com>
>> PR middle-end/61529
>> * tree-ssa-threadupdate.c (compute_path_counts): Bound path_in_freq.
>>
>> gcc/testsuite/ChangeLog:
>>
>> 2014-11-06 Renlin Li <Renlin.Li@arm.com>
>> PR middle-end/61529
>> * gcc.dg/pr61529.c: New.
>
>
> Hi,
>
> Can anybody help to review or approve this?
>
> Kind regards,
> Renlin Li
>
>
--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413