Re: [PATCH][BUILDROBOT] Unused static function (was: RFA: AVR: add infrastructure for device packages)

[Jan-Benedict Glaw <jbglaw at lug-owl dot de>]

On Thu, 2014-10-30 10:46:39 +0400, Denis Chertykov <chertykov@gmail.com> wrote:
> 2014-10-29 13:42 GMT+03:00 Jan-Benedict Glaw <jbglaw@lug-owl.de>:
> > On Wed, 2014-10-29 02:23:31 +0100, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> > > On Wed, 2014-10-08 18:50:32 +0100, Joern Rennecke <joern.rennecke@embecosm.com> wrote:
> > > > Attached is the GCC patch for the basic device package infrastructure.
> > > > OK to apply?
> > > There's some fallout on config-list.mk builds:
> > >
> > > g++ -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/. -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include  -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../gcc/gcc/../libbacktrace    -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/. -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include  -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../gcc/gcc/../libbacktrace   ../../../gcc/gcc/config/avr/driver-avr.c
> > > ../../../gcc/gcc/config/avr/driver-avr.c:35:1: error: âvoid avr_set_current_device(const char*)â defined but not used [-Werror=unused-function]
> > >  avr_set_current_device (const char *name)
> > >  ^
> > > cc1plus: all warnings being treated as errors
> > > make[2]: *** [driver-avr.o] Error 1
> > So I suggest to just remove it.
> >
> > 2014-10-29  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
> >
> >         * config/avr/driver-avr.c (avr_set_current_device): Remove.
> I have not plans to use it.
> Please, apply the patch.

Committed as r216932.

Thanks, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:              TrÃume nicht von Deinem Leben: Lebe Deinen Traum!
the second  :

Attachment: signature.asc
Description: Digital signature