This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH, PR63307] Fix generation of new declarations in random order


> 
> 
> The question remains, are the decls all you need from the traversal (i.e.
> what you need to act upon)?  From my earlier skim of the original code that
> wasn't that obvious.
> You can have in decl_map at least also BLOCKs, perhaps types too, what
> else?

Jakub,

Seems the BLOCKs are the only exception, they can be added in map by
insert_decl_map (&id, wd->block, DECL_INITIAL (inner_fn)); in cilk_outline

In other cases adding to decl_map is being done through add_variable routine which is called only for DECLs (in extract_free_variables)

Your fix for bootstrap looks correct since in cilk_outline we deal with error_mark_node values which are set only for DECLs.


Thanks,
Igor


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]