This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gomp4] Remove gomp_map_vars mem_map argument

From: Thomas Schwinge <thomas at codesourcery dot com>
To: Julian Brown <julian at codesourcery dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, <gcc-patches at gcc dot gnu dot org>
Date: Tue, 28 Oct 2014 20:42:35 +0100
Subject: Re: [gomp4] Remove gomp_map_vars mem_map argument
Authentication-results: sourceware.org; auth=none
References: <20141028165222 dot 2f9a415a at octopus>

Hi Julian!

On Tue, 28 Oct 2014 16:52:22 +0000, Julian Brown <julian@codesourcery.com> wrote:
> This patch removes the now-redundant gomp_memory_mapping argument from
> gomp_map_vars, introduced when OpenACC kept the structure in question
> in a different place from OpenMP. Both now keep the memory map in the
> gomp_device_descr structure, so there's no need to pass both that and
> the memory map to the function explicitly.

Makes sense.

> OK for gomp4 branch?

Yes, thanks!  (But I have not reviewed this code/change in detail.)

>     libgomp/
>     * target.c (gomp_map_vars): Remove MM argument.
>     (GOMP_target, GOMP_target_data): Update calls to gomp_map_vars.
>     * oacc-mem.c (acc_map_data, present_create_copy): Update calls to
>     gomp_map_vars.
>     * oacc-parallel.c (GOACC_parallel, GOACC_data_start): Likewise.
>     * target.h (gomp_map_vars): Update prototype.


GrÃÃe,
 Thomas

Attachment: pgpfORgWPFuMl.pgp
Description: PGP signature

References:
- [gomp4] Remove gomp_map_vars mem_map argument
  - From: Julian Brown

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]