This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work
- From: Ian Taylor <iant at golang dot org>
- To: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
- Cc: Joern Rennecke <joern dot rennecke at embecosm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 27 Oct 2014 09:33:41 -0700
- Subject: Re: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work
- Authentication-results: sourceware.org; auth=none
- References: <CAOyqgcUFmBppk_jDpeO+raujT5P7eNtGrNVH3HbhnSWGRWtbUQ at mail dot gmail dot com> <20141027150658 dot GZ28215 at lug-owl dot de> <CAOyqgcWO+C86WsGphJcwNQkTZSihFucJS5WrvvFN611mhgMb_g at mail dot gmail dot com> <20141027160244 dot GA28215 at lug-owl dot de>
On Mon, Oct 27, 2014 at 9:02 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Mon, 2014-10-27 08:19:34 -0700, Ian Taylor <iant@golang.org> wrote:
>> On Mon, Oct 27, 2014 at 8:06 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>> > On Wed, 2014-10-22 20:36:53 -0700, Ian Taylor <iant@golang.org> wrote:
>> > > This patch to the top level GCC configure script disables the go
>> > > languages on some systems where it is known to not work. Bootstrapped
>> > > on x86_64-unknown-gnu-linux.
>> >
>> > I don't have a clue here, but in what way is Go broken for these
>> > targets? Bacause this patch "breaks" a number of targets mentioned in
>> > contrib/config-list.mk. Maybe Go didn't work on these, but it at
>> > least built. Is it FUBAR there? Or just little fixes needed?
>>
>> I'm not sure exactly what you mean by "breaks," here, as Go is never
>> in the set of default languages. It should only break builds that are
>> using --enable-languages=go. And for those targets, the Go support
>> has never worked, so they were already broken.
>
> With its initial commit in 2010, Joern had Go in the
> --enable-languages list in contrib/config-list.mk . This used to work
> (read: build succeeded), even if Go wouldn't work (or wasn't built
> silently, I didn't check.)
>
> With this slight change in behavior, we'd probably fix
> config-list.mk to reflect these targets where Go would lead to a
> configury failure early.
I think changing config-list.mk is appropriate.
I added this patch to the top-level configure script because someone
observed that it was annoying to configure GCC for Darwin with
--enable-languages=go, have the whole build succeed, and only then
discover that attempts to build Go programs failed with obscure error
messages. That does not serve our users.
Ian