This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi, Sorry for the delay. Here are the updated diff and changelog. gcc/testsuite/ChangeLog: 2014-10-25 Anthony Brandon <anthony.brandon@gmail.com> PR driver/36312 * gcc.misc-tests/output.exp: New test case for identical input and output files. include/ChangeLog: 2014-10-25 Anthony Brandon <anthony.brandon@gmail.com> PR driver/36312 * filenames.h: Add prototype for canonical_filename_eq. gcc/ChangeLog: 2014-10-25 Anthony Brandon <anthony.brandon@gmail.com> PR driver/36312 * diagnostic-core.h: Add prototype for fatal_error. * diagnostic.c (fatal_error): New function fatal_error. * gcc.c (store_arg): Remove have_o_argbuf_index. (process_command): Check if input and output files are the same. * toplev.c (init_asm_output): Check if input and output files are the same. libiberty/ChangeLog: 2014-10-25 Anthony Brandon <anthony.brandon@gmail.com> PR driver/36312 * filename_cmp.c (canonical_filename_eq): New function to check if file names are the same. * functions.texi: Updated with documentation for new function. On Sun, Oct 19, 2014 at 11:17 AM, Manuel LÃpez-IbÃÃez <lopezibanez@gmail.com> wrote: > On 18 October 2014 14:43, Anthony Brandon <anthony.brandon@gmail.com> wrote: >> Never mind about functions.texi. I figured out how to do it. >> Here is the new diff and changelog. >> >> libiberty/ChangeLog: >> >> 2014-10-18 Anthony Brandon <anthony.brandon@gmail.com> >> >> * filename_cmp.c (filename_eq): No change. > > Unfortunately mklog is not 100% perfect (actually, it is 'diff -p' > which is far from perfect). You need to revise that the ChageLog makes > sense (or make mklog smarter). Thus, drop (filename_eq)... > > Also, the changelogs should say PR driver/36312 > (https://gcc.gnu.org/codingconventions.html#ChangeLogs). > > I think you need to explain the difference between using fatal_error() > and fatal_error(UNKNOWN_LOCATION). Yes, I should know because I wrote > this part of the patch. But to be honest, I don't remember why I did > this change. > > +This function first normalizes the file names so that different file names > +pointing to the same underlying file are treated as being identical. > > I would suggest: "This function compares the canonical versions of the > filenames as returned by @code{lrealpath()}, so that ..." > > I cannot approve the patch, but it looks fine to me. If you don't get > a reply in a few days, you should ping the relevant maintainers: > https://gcc.gnu.org/wiki/Community#ping > > Great first contribution! What are your plans next? > > Cheers, > > Manuel. -- Anthony
Attachment:
36312.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |