This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2] [AARCH64,NEON] Convert arm_neon.h to use new builtins for vld[234](q?)_lane_*
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Charles Baylis <charles dot baylis at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 23 Oct 2014 11:14:35 +0100
- Subject: Re: [PATCH 2/2] [AARCH64,NEON] Convert arm_neon.h to use new builtins for vld[234](q?)_lane_*
- Authentication-results: sourceware.org; auth=none
- References: <1412789236-26461-1-git-send-email-charles dot baylis at linaro dot org> <1412789236-26461-3-git-send-email-charles dot baylis at linaro dot org>
On 8 October 2014 18:27, <charles.baylis@linaro.org> wrote:
> +#define __LD2_LANE_FUNC(intype, vectype, largetype, ptrtype, \
Just above the insertion point in arm-neon.h is the comment:
/* Start of temporary inline asm for vldn, vstn and friends. */
This patch removes the "temporary inline asm vldn" implementation, the
replacement implementation should be inserted in the section below,
look for the comment that starts:
"Start of optimal implementations...."
> + mode, ptrmode, funcsuffix, signedtype) \
> +__extension__ static __inline intype __attribute__ ((__always_inline__)) \
> +vld2_lane_##funcsuffix (const ptrtype * __ptr, intype __b, const int __c) \
> +{ \
> + __builtin_aarch64_simd_oi __o; \
> + largetype __temp; \
> + __temp.val[0] = \
There is something odd about the white space here, space before tab?
This is repeated in various places through the rest of the patch.
Otherwise this and the previous 1/2 associated patch look good, can
you respin with these tidy ups?
Thanks
/Marcus