Re: [patch] Second basic-block.h restructuring patch.

[Jiong Wang <jiong dot wang at arm dot com>]

On 20/10/14 19:21, Andrew MacLeod wrote:
> creates cfg.h, cfganal.h, lcm.h, and loop-unroll.h to house the
> prototypes for those .c files.
>
> cfganal.h also gets "struct edge_list"  and "class control_dependences"
> definitions since that is where all the routines and manipulators are
> declared.
>
>    loop-unroll.h only exports 2 routines, so rather than including that
> in basic-block.h I simply included it from the 2 .c files which consume
> those routines.  Again, the other includes will be flattened out of
> basic-block.h to just their consumers later.
>
> loop-unroll.c also had one function I marked as static since it wasn't
> actually used anywhere else.
>
> bootstraps on x86_64-unknown-linux-gnu, and regressions are running... I
> expect no regressions because of the nature of the changes.   OK to
> check in assuming everything is OK?

Happen to start a fresh build

../gcc/configure --target=arm-none-linux-gnueabihf --enable-languages=c,c++

with the following error.

cnumber -I../../gcc/gcc/../libbacktrace    -o loop-doloop.o -MT loop-doloop.o -MMD -MP -MF ./.deps/loop-doloop.TPo ../../gcc/gcc/loop-doloop.c
../../gcc/gcc/loop-doloop.c: In function ‘bool add_test(rtx, edge_def**, basic_block)’:
../../gcc/gcc/loop-doloop.c:371:38: error: ‘split_edge_and_insert’ was not declared in this scope


> Andrew