This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/5] libiberty: Expose choose_tmpdir, and fix constness of return type
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: jit at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 15 Oct 2014 14:56:40 -0400
- Subject: Re: [PATCH 1/5] libiberty: Expose choose_tmpdir, and fix constness of return type
- Authentication-results: sourceware.org; auth=none
- References: <1413222308-25753-1-git-send-email-dmalcolm at redhat dot com> <1413222308-25753-2-git-send-email-dmalcolm at redhat dot com> <543EAFF5 dot 3000403 at redhat dot com>
On Wed, 2014-10-15 at 11:33 -0600, Jeff Law wrote:
> On 10/13/14 11:45, David Malcolm wrote:
> > The jit needs to create a temporary directory, so I need to expose
> > libiberty's choose_tmpdir as a public entrypoint.
> >
> > include/ChangeLog:
> > * libiberty.h (choose_tmpdir): New prototype.
> >
> > libiberty/ChangeLog:
> > * choose-temp.c (choose_tmpdir): Remove now-redundant local
> > copy of prototype.
> > * functions.texi: Regenerate.
> > * make-temp-file.c (choose_tmpdir): Convert return type from
> > char * to const char * - given that this returns a pointer to
> > a memoized allocation, the caller must not touch it.
> OK.
Thanks. Possibly a dumb question, but are there any special procedures
concerning commits to libiberty, given that it appears to be shared with
other gnu projects? (I couldn't find any notes on the website about
this)