This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] Add illegal cilk checks to C++ front.

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Andi Kleen <andi at firstfloor dot org>
Cc: gcc-patches at gcc dot gnu dot org, Andi Kleen <ak at linux dot intel dot com>
Date: Fri, 03 Oct 2014 20:05:57 +0200
Subject: Re: [PATCH 2/2] Add illegal cilk checks to C++ front.
Authentication-results: sourceware.org; auth=none
References: <1412345338-18397-1-git-send-email-andi at firstfloor dot org> <1412345338-18397-2-git-send-email-andi at firstfloor dot org> <1412345338-18397-3-git-send-email-andi at firstfloor dot org> <542ED86D dot 1040308 at oracle dot com> <20141003171332 dot GC12538 at two dot firstfloor dot org> <542EDA10 dot 9060009 at oracle dot com> <20141003175033 dot GD12538 at two dot firstfloor dot org>

Hi,

On 10/03/2014 07:50 PM, Andi Kleen wrote:

I have no idea, but there are lots of error_at() all over while
don't use _.  So I just follow precedence.

The problem is, you are *not* calling error_at directly, you are

According to Joseph it's ok because I named the arguments _msgid.

Ok then, I didn't notice that. Sorry for the false alarm.

Paolo.

References:
- Updated cilk error patches
  - From: Andi Kleen
- [PATCH 1/2] Error out for Cilk_spawn or array expression in forbidden places
  - From: Andi Kleen
- [PATCH 2/2] Add illegal cilk checks to C++ front.
  - From: Andi Kleen
- Re: [PATCH 2/2] Add illegal cilk checks to C++ front.
  - From: Paolo Carlini
- Re: [PATCH 2/2] Add illegal cilk checks to C++ front.
  - From: Andi Kleen
- Re: [PATCH 2/2] Add illegal cilk checks to C++ front.
  - From: Paolo Carlini
- Re: [PATCH 2/2] Add illegal cilk checks to C++ front.
  - From: Andi Kleen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]