This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values

From: Jonathan Wakely <jwakely at redhat dot com>
To: Tim Shen <timshen at google dot com>
Cc: gcc-patches at gcc dot gnu dot org, Paolo Carlini <paolo dot carlini at oracle dot com>, Stefan Schweter <stefan at schweter dot it>, libstdc++ <libstdc++ at gcc dot gnu dot org>
Date: Thu, 2 Oct 2014 09:49:01 +0100
Subject: Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values
Authentication-results: sourceware.org; auth=none
References: <CAG4ZjNmwG1VYrA2cnw7_hhxcHukC01U-DOzfpdjbZhcLgLP_sQ at mail dot gmail dot com> <54156B0B dot 2050006 at oracle dot com> <CAG4ZjNm_PzVYhyonUGOq3fMK8Drj9FNseXepKCts_SGzF=LSkQ at mail dot gmail dot com> <20140915101056 dot GS22778 at redhat dot com> <CAG4ZjNkizOzm+L4T9PRCJp2Ss2LdZYC4Uq02T0DGJpf=77yWWg at mail dot gmail dot com> <20140916092353 dot GX22778 at redhat dot com> <CAG4ZjNkGruTpG1JtzcMDM=R01KmLAx5XkyUhNvw2Yt6tQMP6mw at mail dot gmail dot com> <CAG4ZjN=O+0Z-8FUK4Z-55DQ7Bot0gfXH9CSuuV9+YRz5rqH+BQ at mail dot gmail dot com> <20140930121553 dot GH4197 at redhat dot com> <CAG4ZjNk4Jn2Y2fu_zcMyWwkUbCANtQ4bUsLYfnDBy1s7=iGNpw at mail dot gmail dot com>

On 01/10/14 23:44 -0700, Tim Shen wrote:

This just copies but we could still make it slightly more efficient by
moving _M_original_str (then resetting __rhs to an empty state).

     basic_regex(basic_regex&& __rhs)
     : _M_flags(__rhs._M_flags), _M_original_str(std::move(_M_original_str))
     {
       this->imbue(__rhs.getloc());
       __rhs._M_automaton.reset();
     }

This is only slightly more efficient, and still needs to allocate
memory for the NFA, so I'm not sure if it's worth it. Your call.


Yes let's do it. Done.

Because imbue() returns the old locale you can swap them like this:

       imbue(__rhs.imbue(getloc()));


Done.


Looks good - thanks.

References:
- Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]