This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/2, x86] Add palignr support for AVX2.
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Evgeny Stupachenko <evstupac at gmail dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Richard Henderson <rth at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <rguenther at suse dot de>
- Date: Wed, 1 Oct 2014 13:45:54 +0200
- Subject: Re: [PATCH 1/2, x86] Add palignr support for AVX2.
- Authentication-results: sourceware.org; auth=none
- References: <CAOvf_xygAivauU2_s2dzCKt5nCZ_AbsTXOpj4u+ceg4ffvGhgA at mail dot gmail dot com> <CAOvf_xxr00v6dk=0EfS3ZETStdtT7OfczLD=xJs=-VGqc3nsdw at mail dot gmail dot com> <CAOvf_xw8+ojk8W6gP_eLBxdvT0rsTLmGsYKzGig4mJ7Y7xUmFA at mail dot gmail dot com> <CAMe9rOq-2yktd-BF89xRdh+xCnMwzSGSfz=atr83mcTU6_b8cg at mail dot gmail dot com> <CAOvf_xz4W7dn3F-VnWowSG211s8WcU2Qo_8+c1rcNAYwh-k7+g at mail dot gmail dot com> <CAMe9rOoaQ90P9wb4m5ch5W-bPh5-1xvmCMQnd9Sc9meoJ0unNQ at mail dot gmail dot com> <CAOvf_xxiLsTCZSEHJ8DLdD7kRHRTHHSjZXWyNPu3H-6xnSfCsA at mail dot gmail dot com> <CAOvf_xyNC1mRGNrM1kU_nNz_tO6_M4T8wox75D+zndhY5=TVAQ at mail dot gmail dot com> <CAFULd4bfOLW2kOmSndwK=LdNbUwHR1Ogds+5_AZ7j=tH=zu12w at mail dot gmail dot com> <20141001103514 dot GO1986 at tucnak dot redhat dot com> <20141001113815 dot GQ1986 at tucnak dot redhat dot com>
On Wed, Oct 1, 2014 at 1:38 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> That doesn't compile, will post a new version; got interrupted when
>> I found that in
>> GCC_TEST_RUN_EXPENSIVE=1 make check-gcc RUNTESTFLAGS='--target_board=unix/-mavx2 dg-torture.exp=vshuf*.c'
>> one test is miscompiled even with unpatched compiler, debugging that now.
>
> Let's start with the bugfix. The || doesn't make any sense, and we really
> want to fill in 4 bits (0, 1, 4, 5) of the immediate, not just two, anyway.
> valid_perm_using_mode_p (V2TImode, d) should already guarantee that
> it is possible to permutate it as V2TI, so all we care about are the
> values of d->perm[0] and d->perm[nelt / 2], but we care not just which
> lane it is, but also which operand (src1 or src2).
>
> Tested with
> GCC_TEST_RUN_EXPENSIVE=1 make check-gcc RUNTESTFLAGS='--target_board=unix/-mavx2 dg-torture.exp=vshuf*.c'
> Ok for trunk/4.9/4.8?
>
> 2014-10-01 Jakub Jelinek <jakub@redhat.com>
>
> PR target/63428
> * config/i386/i386.c (expand_vec_perm_pshufb): Fix up rperm[0]
> argument to avx2_permv2ti.
>
> * gcc.dg/torture/vshuf-4.inc: Move test 122 from EXPTESTS
> to test 24 in TESTS.
OK.
Thanks,
Uros.