This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [libstdc++] Refactor python/hook.in

From: Jonathan Wakely <jwakely at redhat dot com>
To: Siva Chandra <sivachandra at google dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>, Jonathan Wakely <jwakely dot gcc at gmail dot com>, Tom Tromey <tom at tromey dot com>
Date: Tue, 30 Sep 2014 16:34:02 +0100
Subject: Re: [libstdc++] Refactor python/hook.in
Authentication-results: sourceware.org; auth=none
References: <CAGyQ6gyqMPZyJMN6326qtAzSTAAc1azodk5Jx3ZtMoFYM5puOQ at mail dot gmail dot com> <20140929131116 dot GB4197 at redhat dot com>

On 29/09/14 14:11 +0100, Jonathan Wakely wrote:

On 29/09/14 06:02 -0700, Siva Chandra wrote:

The attached patch refactors python/hook.in so that there are no
individual function calls to load pretty printers and xmethods. This
was suggested by Tom here:
https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02589.html. He indicates
that it is better to put as little as possible in the hook file. The
attached patch removes all code which explicitly loads the hooks from
hook.in.


This looks good to me, thanks.

I'll commit it later this week unless I hear objections from Tom.


Committed to trunk - thanks for the patch.

References:
- [libstdc++] Refactor python/hook.in
  - From: Siva Chandra
- Re: [libstdc++] Refactor python/hook.in
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]