This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C

From: Jeff Law <law at redhat dot com>
To: Thomas Schwinge <thomas at codesourcery dot com>, "Tannenbaum, Barry M" <barry dot m dot tannenbaum at intel dot com>, "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>, "Zamyatin, Igor" <igor dot zamyatin at intel dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 29 Sep 2014 09:24:40 -0600
Subject: Re: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C
Authentication-results: sourceware.org; auth=none
References: <BF230D13CA30DD48930C31D4099330003A455EF0 at FMSMSX101 dot amr dot corp dot intel dot com> <52012923 dot 6030409 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A457F85 at FMSMSX101 dot amr dot corp dot intel dot com> <5204C718 dot 9050402 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A458F86 at FMSMSX101 dot amr dot corp dot intel dot com> <5214DD51 dot 9030709 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A45AE69 at FMSMSX101 dot amr dot corp dot intel dot com> <521641C6 dot 6060807 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A45D457 at FMSMSX101 dot amr dot corp dot intel dot com> <87vbof3gji dot fsf at kepler dot schwinge dot homeip dot net> <6B86B7F2A4026246AA81BA1ABF9756905C4FF96C at FMSMSX105 dot amr dot corp dot intel dot com> <8761g6g0je dot fsf at kepler dot schwinge dot homeip dot net> <6B86B7F2A4026246AA81BA1ABF9756905C50C72F at fmsmsx107 dot amr dot corp dot intel dot com> <87vbo67ba6 dot fsf at schwinge dot name>

On 09/29/14 08:26, Thomas Schwinge wrote:

Hi!

On Mon, 29 Sep 2014 13:58:31 +0000, "Tannenbaum, Barry M" <barry.m.tannenbaum@intel.com> wrote:

In a nutshell, add the following code to main() before the call to f3():

     int status = __cilkrts_set_param("nworkers", "2");
     if (0 != status) {
         // Failed to set the number of Cilk workers
         return status;
     }


Yeah, that's what I had proposed with the patch at the end of my previous
email,
<http://news.gmane.org/find-root.php?message_id=%3C8761g6g0je.fsf%40kepler.schwinge.homeip.net%3E>.
I'm sorry if I didn't make it obvious that more text and the patch were
following after the full-quote of the original issue description.

Here's the details: [...]


Thanks again for your helpful comments; that's appreciated.

Here's again my proposed patch.  Note, that the include paths in GCC
compiler testing (gcc/testsuite/) are not set up to pick up the
<cilk/cilk_api.h> include file, so I've manually added a propotype for
the __cilkrts_set_param function to the three files.  I can change that,
if requested.

commit ee7138e451d1f3284d6fa0f61fe517c82db94060
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Mon Sep 29 12:47:34 2014 +0200

     Audit Cilk Plus tests for CILK_NWORKERS=1.

     	gcc/testsuite/
     	* c-c++-common/cilk-plus/CK/spawning_arg.c (main): Call
     	__cilkrts_set_param to set two workers.
     	* c-c++-common/cilk-plus/CK/steal_check.c (main): Likewise.
     	* g++.dg/cilk-plus/CK/catch_exc.cc (main): Likewise.

OK.
Jeff

References:
- Re: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C
  - From: Thomas Schwinge
- RE: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C
  - From: Tannenbaum, Barry M
- RE: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C
  - From: Thomas Schwinge
- RE: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C
  - From: Tannenbaum, Barry M
- RE: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C
  - From: Thomas Schwinge

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]