This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] PR libitm/61164: use always_inline consistently


On Sat, Sep 27, 2014 at 09:00:00PM +0400, Gleb Fotengauer-Malinovskiy wrote:
> 2014-09-27 Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
> 
> libitm/
> 
> 	PR libitm/61164
> 	* local_atomic (__always_inline): Add inline.
> 	(__calculate_memory_order): Remove inline.
> 	(atomic_thread_fence): Likewise.
> 	(atomic_signal_fence): Likewise.
> 	(atomic_flag_test_and_set_explicit): Likewise.
> 	(atomic_flag_clear_explicit): Likewise.
> 	(atomic_flag_test_and_set): Likewise.
> 	(atomic_flag_clear): Likewise.
> 
> ---
> Sorry, previous patch is incomplete.

This patch doesn't seem to match the ChangeLog, there is
no change in the #define, etc.

Furthermore, I think it is just wrong to redefine a glibc
macro.  I'd suggest to just
sed -i -e 's/__always_inline/__libitm_always_inline/g' libitm/local_atomic

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]