This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix whitespace in comments.

From: Jeff Law <law at redhat dot com>
To: Tobias Burnus <burnus at net-b dot de>, Thomas Koenig <tkoenig at netcologne dot de>, VandeVondele Joost <joost dot vandevondele at mat dot ethz dot ch>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>
Date: Mon, 22 Sep 2014 18:05:55 -0600
Subject: Re: [PATCH] Fix whitespace in comments.
Authentication-results: sourceware.org; auth=none
References: <908103EDB4893A42920B21D3568BFD9315105FDE at MBX13 dot d dot ethz dot ch> <541D50BA dot 6030906 at netcologne dot de> <541D93AD dot 4050109 at net-b dot de>

On 09/20/14 08:48, Tobias Burnus wrote:

Hi Joost and Thomas,

On 20.09.2014 12:02, Thomas Koenig wrote:

A somewhat trivial patch to cleanup whitespace issues in comments:
sed "s/\. \*\//\.  \*\//g"
Tested with a recompile only. Ok for trunk ?

OK.  (Obvious, really).


I want to point a downside of massive code changes: It makes it more
difficult to find out with "git/svn blame" when or why a line of code
was changed.

That's not so much a problem of comment changes like this one – and I am
fine with that change. :-)

However, I wanted to point out that seemingly trivial and obviously
correct patches can have a downside. (One can still do such changes, but
at least one should have weighted them against the downside.)

Yup.

I still want a commit hook which cleans this kind of stuff up so that wecan be done with worry about this kind of stuff.


jeff

References:
- [PATCH] Fix whitespace in comments.
  - From: VandeVondele Joost
- Re: [PATCH] Fix whitespace in comments.
  - From: Thomas Koenig
- Re: [PATCH] Fix whitespace in comments.
  - From: Tobias Burnus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]