Re: [BUILDROBOT] genrecog fix uncovers problem in bfin.md (was: [Patch] Teach genrecog/genoutput that scratch registers require write constraint modifiers)

[James Greenhalgh <james dot greenhalgh at arm dot com>]

On Sat, Sep 20, 2014 at 08:40:01PM +0100, Jan-Benedict Glaw wrote:
> Hi!
> 
> On Thu, 2014-09-18 11:19:21 +0100, James Greenhalgh <james.greenhalgh@arm.com> wrote:
> > As discussed in https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01334.html
> > The construct
> > 
> >   (clobber (match_scratch 0 "r"))
> > 
> > is invalid - operand 0 must be marked either write or read/write.
> > 
> > Likewise
> > 
> >   (match_* 0 "&r")
> > 
> > is invalid, marking an operand earlyclobber does not remove the need to
> > also mark it write or read/write.
> 
> My build robot shows a new build error, which I guess is
> caused/uncovered by your genrecog change on bfin-elf (see eg. build
> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=355667):
> 
> build/genrecog /home/jbglaw/repos/gcc/gcc/common.md /home/jbglaw/repos/gcc/gcc/config/bfin/bfin.md \
>   insn-conditions.md > tmp-recog.c
> /home/jbglaw/repos/gcc/gcc/config/bfin/bfin.md:1971: constraints not supported in define_split
> make[1]: *** [s-recog] Error 1
> make[1]: Leaving directory `/home/jbglaw/build/bfin-elf/build-gcc/gcc'
> make: *** [all-gcc] Error 2
> 
> 
> Would be nice if the bfin maintainer or you would come up with a fix.

Hi Jan,

I posted a fix for this on Friday evening at:

  https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01682.html

I'm waiting for a bfin maintainer to say OK, as it isn't a port I know
well.

Thanks,
James