This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [kyukhin/gomp4-offload] DESTDIR issues
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: Jakub Jelinek <jakub at redhat dot com>, Ilya Verbin <iverbin at gmail dot com>, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Bernd Schmidt <bernds at codesourcery dot com>, Alexandre Oliva <aoliva at redhat dot com>, DJ Delorie <dj at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 17 Sep 2014 16:04:25 +0200
- Subject: Re: [kyukhin/gomp4-offload] DESTDIR issues
- Authentication-results: sourceware.org; auth=none
- References: <20140917133144 dot GF17454 at tucnak dot redhat dot com>
Il 17/09/2014 15:31, Jakub Jelinek ha scritto:
> It seems building of the host compiler requires the offloading compiler
> to be installed directly in the prefix, which is something really
> undesirable e.g. for distro builds where things are installed with
> non-empty $(DESTDIR).
Is the offloading compiler built together with GCC or previously? If
the latter, what's the difference between the offloading compiler and
say gmp? Setting the LD_LIBRARY_PATH would be the responsibility of
whoever builds GCC; it would be the same here for the COMPILER_PATH.
> Either we can do something like the following patch, i.e. look
> at -I$(DESTDIR)/$(target_dir)/include first and fall back to
> -I$(target_dir)/include, which fixed the build for me, but unfortunately
> it violates GNU conventions:
> https://www.gnu.org/prep/standards/html_node/DESTDIR.html
> "DESTDIR should be supported only in the install* and uninstall* targets, as
> those are the only targets where it is useful."
> while this patch uses it during build.
I agree with the coding standards. The right way to do it could be a
configure option, if it's really not possible to leave it to whoever
builds GCC.
Paolo