This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Avoid inter-test dependencies in gfortran.dg (PR fortran/56408)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: VandeVondele Joost <joost dot vandevondele at mat dot ethz dot ch>, Tobias Burnus <burnus at net-b dot de>, Mike Stump <mikestump at comcast dot net>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>
- Date: Tue, 16 Sep 2014 11:21:29 +0200
- Subject: Re: [PATCH] Avoid inter-test dependencies in gfortran.dg (PR fortran/56408)
- Authentication-results: sourceware.org; auth=none
- References: <20140915161347 dot GN17454 at tucnak dot redhat dot com> <908103EDB4893A42920B21D3568BFD9315104045 at MBX13 dot d dot ethz dot ch> <20140916084246 dot GQ17454 at tucnak dot redhat dot com> <20140916084717 dot GR17454 at tucnak dot redhat dot com> <908103EDB4893A42920B21D3568BFD931510409E at MBX13 dot d dot ethz dot ch> <mvmtx48x6yu dot fsf at hawking dot suse dot de>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Sep 16, 2014 at 11:14:33AM +0200, Andreas Schwab wrote:
> "VandeVondele Joost" <joost.vandevondele@mat.ethz.ch> writes:
>
> >>> What dejagnu version are you using?
> >
> >> runtest --version
> > WARNING: Couldn't find the global config file.
> > Expect version is 5.44.1.15
> > Tcl version is 8.5
> > Framework version is 1.4.4
>
> You need at least dejagnu 1.5, which includes this fix:
>
> http://git.savannah.gnu.org/cgit/dejagnu.git/commit/?id=fd70857
BTW, even that change doesn't look right to me,
with nested calls, my reading of the change is that in case of
nested calls, the outer one will rename unknown to dg-save-unknown,
then inner call will not rename anything because dg-save-unknown
already exists, then when about to return, the nested call will rename
dg-save-unknown to unknown (but, I'd say that it should be the outer, not
inner call that does that), then the outer call will not rename anything.
So, either it can use a trick with [info level] I've used, or just remember
in some local variable if a particular call renamed it and only if it did,
rename it back.
Jakub