This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH 3/4] AArch64: Cleanup inconsistent use of __extension__
- From: "Wilco Dijkstra" <wdijkstr at arm dot com>
- To: "'Marcus Shawcroft'" <marcus dot shawcroft at gmail dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 11 Sep 2014 16:14:59 +0100
- Subject: RE: [PATCH 3/4] AArch64: Cleanup inconsistent use of __extension__
- Authentication-results: sourceware.org; auth=none
- References: <000e01cfc84e$deb434f0$9c1c9ed0$ at com> <CAFqB+Px5_GtmvWNTzh6vJQYzSKi=U-T1RY2dQg01O2bo833xFw at mail dot gmail dot com> <CAFqB+Px0DmWVYG3FFE1J+d_s_eidE2k8adGS0oFf5m2OVSO0kQ at mail dot gmail dot com>
OK, I'll skip this patch for now as HAVE_DESIGNATED_INITIALIZERS should
always be false, so there is no point in cleaning it up.
> -----Original Message-----
> From: Marcus Shawcroft [mailto:marcus.shawcroft@gmail.com]
> Sent: 04 September 2014 16:42
> To: Wilco Dijkstra
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH 3/4] AArch64: Cleanup inconsistent use of __extension__
>
> On 4 September 2014 16:39, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote:
> > On 4 September 2014 15:45, Wilco Dijkstra <wdijkstr@arm.com> wrote:
> >> Cleanup inconsistent use of __extension__.
> >>
> >> ChangeLog:
> >> 2014-09-04 Wilco Dijkstra <wdijkstr@arm.com>
> >>
> >> * gcc/config/aarch64/aarch64.c: Cleanup use of __extension__.
> >
> > Write a proper ChangeLog entry please.
> > /Marcus
>
>
> Actually, on second thoughts, I think it better to just remove the
> three lines of the first spurious instance of:
>
> #if HAVE_DESIGNATED_INITIALIZERS && GCC_VERSION >= 2007
> __extension__
> #endif
>
> and leave the other instances alone.
>
> /Marcus