This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] No allocation for empty unordered containers

From: Jonathan Wakely <jwakely at redhat dot com>
To: François Dumont <frs dot dumont at gmail dot com>
Cc: libstdc++ at gcc dot gnu dot org, Paolo Carlini <paolo dot carlini at oracle dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 9 Sep 2014 22:31:13 +0100
Subject: Re: [patch] No allocation for empty unordered containers
Authentication-results: sourceware.org; auth=none
References: <53E13810 dot 8030107 at gmail dot com> <20140805201026 dot GH6927 at redhat dot com> <53E13D4B dot 5080909 at oracle dot com> <53EA697F dot 4030407 at gmail dot com> <alpine dot DEB dot 2 dot 11 dot 1408122137280 dot 1593 at laptop-mg dot saclay dot inria dot fr> <53EA70B6 dot 20503 at gmail dot com> <20140813095026 dot GU6927 at redhat dot com> <53ED0C8D dot 5020809 at gmail dot com> <20140909172900 dot GE22778 at redhat dot com> <540F6B0C dot 9070302 at gmail dot com>

On 09/09/14 23:03 +0200, François Dumont wrote:

On 09/09/2014 19:29, Jonathan Wakely wrote:
On 14/08/14 21:22 +0200, François Dumont wrote:
I am preparing a patch for profile mode so I will submitmodification for this mode with this big patch.
btw, François, for profile mode I think we should just do something
like this patch.

I feel quite strongly that if using Debug Mode or Profile Mode makes
your program run out of memory where it wouldn't usually fail, then
terminating is reasonable. The point of Profile Mode is not to test
abnormal execution of your program because that won't give you useful
profile information for the normal case.

It's more important for the noexcept specification to be consistent
across normal/debug/profile modes than for profile mode to fail
gracefully via bad_alloc in out-of-memory scenarios.
Sure, no problem. In the patch I am preparing for profile modefailure in allocation will just mean that the involved container won'tbe profiled so that I can add noexcept wherever it is needed forconsistency with normal mode. I hope to be able to submit this patchin a week or two.


Great - thanks for working on it.

References:
- Re: [patch] No allocation for empty unordered containers
  - From: Jonathan Wakely
- Re: [patch] No allocation for empty unordered containers
  - From: François Dumont

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]