This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add -fno-instrument-function
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Andi Kleen <ak at linux dot intel dot com>
- Cc: Andi Kleen <andi at firstfloor dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 3 Sep 2014 13:03:55 +0200
- Subject: Re: [PATCH] Add -fno-instrument-function
- Authentication-results: sourceware.org; auth=none
- References: <1409603138-18755-1-git-send-email-andi at firstfloor dot org> <CAFiYyc3=wWNqWUy5NEFxWBphKGBhFnGb2-JNb=zT-5o5cOnr4Q at mail dot gmail dot com> <20140902150015 dot GG25920 at tassilo dot jf dot intel dot com>
On Tue, Sep 2, 2014 at 5:00 PM, Andi Kleen <ak@linux.intel.com> wrote:
>> Hmm, why not make -no-pg (does that exist?) and/or -mno-fentry
>
> I'm not sure.
>
>> do this? That is, I don't see the need for a new option.
>
> That would be really odd behavior. An yes/no option whose default
> is controlled by other object files' command line.
> And -pg would be for all files in LTO, and no-pg only for that file,
> so not be symmetric.
>
> I think an explicit different option has far cleaner semantics for
> now (at least until the LTO option mess can be properly cleaned up)
No, not a new "fake" option either but just initialize
DECL_NO_INSTRUMENT_FUNCTION_ENTRY_EXIT properly when
not doing -pg or -mfentry (that is, set it to 1).
Richard.
> -Andi