This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Force rtl templates to be inlined
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: Andrew Pinski <pinskia at gmail dot com>, Andi Kleen <andi at firstfloor dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Andi Kleen <ak at linux dot intel dot com>, David Malcolm <dmalcolm at redhat dot com>
- Date: Tue, 2 Sep 2014 10:43:27 +0200
- Subject: Re: [PATCH] Force rtl templates to be inlined
- Authentication-results: sourceware.org; auth=none
- References: <1409641427-29875-1-git-send-email-andi at firstfloor dot org> <CA+=Sn1nJAiKUOZB_QA4D_VHKAH6KiW9aNP2rJPCdJqTOvFZzFA at mail dot gmail dot com> <20140902072019 dot GX4120 at two dot firstfloor dot org> <CA+=Sn1kCQrAysb7zA6Oka5eCAkwrfgZeps65opntNE-e1V+dng at mail dot gmail dot com> <CABu31nO=TQKLatDFRvJBZo_JfCMstSzxm=_PGiig97fQqkHUxQ at mail dot gmail dot com>
On Tue, Sep 2, 2014 at 10:36 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Tue, Sep 2, 2014 at 9:22 AM, Andrew Pinski wrote:
>> On Tue, Sep 2, 2014 at 12:20 AM, Andi Kleen wrote:
>>>
>>>> there have been bugs in the past in the area of always_inline too.
>>>
>>> You're arguing for my patch. It would find those bugs.
>>
>>
>> No I am arguing against it since the older versions of GCC we cannot change.
>
> Should such bugs turn up, we can account for them in ansidecl.h.
>
> I think Andi's patch should go in.
I disagree. always-inline isn't an optimization attribute but a correctness
one.
Instead we should not build stage1 with -O0 if we detect a reasonably
recent GCC host compiler (say one that is still maintained). Or
we simply should make -finline work at -O0 (I suppose it might already
work?) and use it.
Richard.
> Ciao!
> Steven