This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH 3/4] aarch64: Tidy prologue local variables
- From: Jiong Wang <jiong dot wang at arm dot com>
- To: Richard Henderson <rth at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Thu, 28 Aug 2014 17:55:05 +0100
- Subject: Re: [PATCH 3/4] aarch64: Tidy prologue local variables
- Authentication-results: sourceware.org; auth=none
- References: <1408745131-24297-1-git-send-email-rth at redhat dot com> <1408745131-24297-4-git-send-email-rth at redhat dot com> <53FC8481 dot 6090209 at arm dot com> <53FF5D59 dot 5080909 at redhat dot com>
On 28/08/14 17:48, Richard Henderson wrote:
On 08/26/2014 05:58 AM, Jiong Wang wrote:
there is a field "hardfp_offset" in aarch64_frame, and I think that field is
not used and not initialized correctly.
how about hoisting the calculation to aarch64_layout_frame to avoid duplicated
calcuation here and there, something like:
cfun->machine->frame.hardfp_offset = (cfun->machine->frame.frame_size-
then use it directly in expand_epilogue:
fp_offset = cfun->machine->frame.hardfp_offset;
I'd go the other way, and simply delete hardfp_offset as unused. We need the
other two inputs to the subtraction for other reasons, so we don't save
anything by pre-computing the subtract.