This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH GCC]Fix broken Canadian when checking isl library support
- From: Sebastian Pop <sebpop at gmail dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Bin Cheng <bin dot cheng at arm dot com>, Tobias Grosser <tobias at grosser dot es>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 28 Aug 2014 16:46:10 +0000
- Subject: Re: [PATCH GCC]Fix broken Canadian when checking isl library support
- Authentication-results: sourceware.org; auth=none
- References: <000801cfbd19$ec953ff0$c5bfbfd0$ at arm dot com> <CAFiYyc3xWR7kz=GHYbC4g36oTAn3jWEKj0W2460JosSB_fqesQ at mail dot gmail dot com> <20140825191857 dot GA27780 at instance-1 dot c dot bardezibar dot internal> <20140825210748 dot GA19958 at instance-1 dot c dot bardezibar dot internal> <CAFiYyc3mdixY_kRMTvbGqe3ckfjKizrT3X5sJ1djT8fh-eTfUg at mail dot gmail dot com>
Richard Biener wrote:
> On Mon, Aug 25, 2014 at 11:07 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> > Sebastian Pop wrote:
> >> Richard Biener wrote:
> >> > I think it would be better to identify a set of features we rely on that
> >> > are not present in earlier versions and make the test a link
> >> > test unconditionally.
> >> >
> >> > Tobias, are there include files / types / functions we require
> >> > that are not available in earlier versions?
> >>
> >> The version 0.12 of ISL has an include file isl/val.h that is not present in
> >> previous versions of ISL.
> >>
> >> There also was a patch from Mircea a few weeks ago that was missing the
> >> configure bits to check that the isl version contained isl/val.h.
> >> I will update both patches and submit for review.
> >
> > I see that Mircea's patch has been committed:
> >
> > commit c5ec3cc336c7d42d9ad2995395d430b99a9a34cc
> > Author: mircea <mircea@138bc75d-0d04-0410-961f-82ee72b054a4>
> > Date: Mon Aug 11 15:05:48 2014 +0000
> >
> > Replacement of isl_int by isl_val
> >
> > git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@213816 138bc75d-0d04-0410-961f-82ee72b054a4
> >
> > Attached a patch to check for isl/val.h instead of ISL's release number.
> >
> > Bootstrapping on x86-64. Ok to commit?
>
> Ok. I suppose the "checking for version 0.12 of ISL" is now slightly
> misleading - maybe change it to "checking for compatible ISL"?
Committed r214683 with the suggested change.