This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 23 bytes

On 08/28/2014 05:19 AM, Jeff Law wrote:
> On 08/21/14 15:44, Chen Gang wrote:
>> int_size_in_bytes() returns HOST_WIDE_INT (64-bit), theoretically, the
>> maximized size is 23 -- it is sizeof("[-9223372036854775808]") for
>> 0x8000000000000000LL.
>> It may not cause real world issue, but if another issues occur, it may
>> lead things worse.
>> It passes normal testsuite: "../gcc/configure && make && make check" is
>> OK. And 'contrib/compare_tests' is OK, too, the related output is:
>>    # Comparing directories
>>    ## Dir1=/upstream/build-gcc: 11 sum files
>>    ## Dir2=/upstream/build-gcc-new: 11 sum files
>>    # Comparing 11 common sum files
>>    ## /bin/sh ./compare_tests  /tmp/gxx-sum1.7678 /tmp/gxx-sum2.7678
>>    # No differences found in 11 common sum files
>> 2014-08-17  Chen Gang  <>
>>     * c/c-aux-info.c (gen_type): Resize 'buff' from 10 to 23 bytes,
>>     with using HOST_WIDE_INT without truncation to 'int'
> Thanks.  Installed.

Thanks you for your work.

After sent (I just sent) another trivial patch to familiar testsuite
again, I shall analyze the failure about my microblaze related patch,
hope I can finish within next month.

And after finish analyzing microblaze related patch, I shall try to
analyze the testsuite failures under my mac book, and try to let it
pass testsuite, too.

Chen Gang

Open share and attitude like air water and life which God blessed

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]