This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 23 bytes
- From: Chen Gang <gang dot chen dot 5i5j at gmail dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, Mike Stump <mikestump at comcast dot net>, "Bin.Cheng" <amker dot cheng at gmail dot com>, rth at redhat dot com, "ea >> Michael Eager" <eager at eagercon dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 28 Aug 2014 06:49:11 +0800
- Subject: Re: [PATCH v2] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 23 bytes
- Authentication-results: sourceware.org; auth=none
- References: <53F6682F dot 1080709 at gmail dot com> <53FE4B76 dot 7060007 at redhat dot com>
On 08/28/2014 05:19 AM, Jeff Law wrote:
> On 08/21/14 15:44, Chen Gang wrote:
>> int_size_in_bytes() returns HOST_WIDE_INT (64-bit), theoretically, the
>> maximized size is 23 -- it is sizeof("[-9223372036854775808]") for
>> 0x8000000000000000LL.
>>
>> It may not cause real world issue, but if another issues occur, it may
>> lead things worse.
>>
>> It passes normal testsuite: "../gcc/configure && make && make check" is
>> OK. And 'contrib/compare_tests' is OK, too, the related output is:
>>
>> # Comparing directories
>> ## Dir1=/upstream/build-gcc: 11 sum files
>> ## Dir2=/upstream/build-gcc-new: 11 sum files
>>
>> # Comparing 11 common sum files
>> ## /bin/sh ./compare_tests /tmp/gxx-sum1.7678 /tmp/gxx-sum2.7678
>> # No differences found in 11 common sum files
>>
>>
>> 2014-08-17 Chen Gang <gang.chen.5i5j@gmail.com>
>>
>> * c/c-aux-info.c (gen_type): Resize 'buff' from 10 to 23 bytes,
>> with using HOST_WIDE_INT without truncation to 'int'
> Thanks. Installed.
>
Thanks you for your work.
After sent (I just sent) another trivial patch to familiar testsuite
again, I shall analyze the failure about my microblaze related patch,
hope I can finish within next month.
And after finish analyzing microblaze related patch, I shall try to
analyze the testsuite failures under my mac book, and try to let it
pass testsuite, too.
Thanks
--
Chen Gang
Open share and attitude like air water and life which God blessed