This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ RFH/Patch] PR 52892 (and others)


Hi,

On 08/27/2014 04:19 PM, Jason Merrill wrote:
On 08/27/2014 04:41 AM, Paolo Carlini wrote:
.. two additional remarks (maybe obvious, I don't know):
- It also appears to work - for sure for all the tests in c++/52892 +
the tests in c++/52282 not involving data members (eg, the original one)
- simply unconditionally calling STRIP_NOPS right after the
cxx_eval_constant_expression at the beginning of
cxx_eval_call_expression (or calling it only when, after the fact, we
know it wraps a function pointer).
- Grepping in semantics.c reveals that in quite a few other places we
make sure to STRIP_NOPS before checking for ADDR_EXPR, it seems a
general issue.
True.  OK, let's go ahead with your approach.
Thanks, let's give it a try at least, you know that I don't hesitate to revert patches which give problems ;)

When testing completes again I mean to apply the below, the simplest variant.

Thanks,
Paolo.

//////////////////////

Attachment: CL_52892
Description: Text document

Attachment: patch_52892
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]