This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, AArch64] Fix typo

On 15/08/14 17:24, Evandro Menezes wrote:
> I tripped at a typo that goes undetected because the macro NAMED_PARAM
> doesn't apply in the absence of designated initializers.
> Since struct scale_addr_mode_cost has the cost for DI, but not for QI, the
> instances of struct cpu_addrcost_table are not initialized as intended due
> to the different order of the structure members.  

The fix is OK, but the ChangeLog entry is not.

1) This change should be recorded in gcc/ChangeLog
2) The leading gcc/ part of the filename is then not needed
3) The text is inadequate.  You need to mention the names of the objects
that have been changed (generic_addrcost_table, etc in this instance)
and what changed.
4) ChangeLog entries should not be included in diff format - the diff
will never apply in practice and it just makes more work for the
reviewers to fix things up.  Put the ChangeLog data in the main body of
the mail.

I've fixed all that up this time and committed it as follows:


2014-08-26  Evandro Menezes <>

	* config/arm/aarch64/aarch64.c (generic_addrcost_table): Delete
	qi cost; add di cost.
	(cortexa57_addrcost_table): Likewise.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]