This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] use vec<> in frontend-passes.c


Hi Thomas, hi all,

first, thanks Trevor for the first round of review!

Thomas Koenig wrote:
> Trevor Saunders wrote:
> > >    doloop_warn (ns);
> > > -  XDELETEVEC (doloop_list);
> > > +  doloop_list.truncate (0);
> >
> > .release () would be more typical.
>
> Changed (also below).

I still see:
> -  expr_count = 0;
> +  expr_array.truncate (0);

Is there is a reason for not using release() here?

Otherwise, it looks good to me - and cleaner than the home-grown stack.

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]