This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Fix __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__


So I should just take that particular check out then?

James Clarke

> On 25 Aug 2014, at 21:05, Mike Stump <mikestump@comcast.net> wrote:
> 
>> On Aug 25, 2014, at 11:03 AM, James Clarke <jrtc27@jrtc27.com> wrote:
>> Previously, this macro had taken the form 10X0, where X is the minor
>> version number, e.g. 1090 for OS X 10.9 Mavericks. However, as of OS X
>> 10.10 Yosemite, it should take the form 10XX00, i.e. 101000 for 10.10.
> 
> So, if they continue using the same scheme, Iâd prefer to future proof this (I donât like software time bombs) so that 10.11.0 works as well as 10.12.0 and so on.
> 
> We didnât do this last time, as we were unsure how the numbers would work out.  Now, it is much safer to see what the likely format will be.
> 
> Could you try that?
> 
>> -  if (major_vers > 4 + 9)
>> +  if (major_vers > 4 + 10)
> 
> I think this is the only thing that has to change.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]