This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, nios2] testsuite cleanup
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: Mike Stump <mikestump at comcast dot net>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 23 Aug 2014 14:36:35 -0400 (EDT)
- Subject: Re: [patch, nios2] testsuite cleanup
- Authentication-results: sourceware.org; auth=none
- References: <53F6098F dot 9000506 at codesourcery dot com> <3BE409FD-12EE-4048-8B2B-B32ECEA9256C at comcast dot net> <53F63384 dot 1090005 at codesourcery dot com> <A9B014B0-18AC-47C1-A7A0-DEA94968B8D1 at comcast dot net> <alpine dot BSF dot 2 dot 02 dot 1408221844330 dot 65012 at arjuna dot pair dot com> <0DB8B7F0-5471-46F4-BD40-FF1D6491F32D at comcast dot net> <53F8C33B dot 7080303 at codesourcery dot com>
On Sat, 23 Aug 2014, Sandra Loosemore wrote:
> On 08/23/2014 10:26 AM, Mike Stump wrote:
> > On Aug 22, 2014, at 3:48 PM, Hans-Peter Nilsson <hp@bitrange.com> wrote:
> > >
> > > > +/* non default branch cost */
> > > > +/* { dg-do run { target { ! "m68k*-*-* mmix*-*-* mep*-*-* bfin*-*-*
> > > > v850*-*-* picochip*-*-* moxie*-*-* cris*-*-* m32c*-*-* fr30*-*-*
> > > > mcore*-*-* powerpc*-*-* xtensa*-*-* hppa*-*-* nios2*-*-*"} } } */
> >
> > > It's the other way round re "listed targets". (CRIS and MMIX
> > > have the default branch cost, ditto m68k and moxie, didn't check
> > > the others.)
> >
> > Right. I had ! on the brain. Do you like non-default branch cost, or would
> > it
> > be better to describe it some other way?
>
> If we're going to go through the trouble of adding a comment here, we might as
> well make it something less terse and more explicit, like:
>
> These tests fail unless the target backend overrides BRANCH_COST to return a
> value >= 2.
Agreed!
The target list line is getting longish, maybe put it in an
effective-target proc while it's being edited anyway.
brgds, H-P