This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 041/236] Debug hooks: use rtx_insn and rtx_code_label
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 21 Aug 2014 04:18:30 -0400
- Subject: Re: [PATCH 041/236] Debug hooks: use rtx_insn and rtx_code_label
- Authentication-results: sourceware.org; auth=none
- References: <1407345815-14551-1-git-send-email-dmalcolm at redhat dot com> <1407345815-14551-42-git-send-email-dmalcolm at redhat dot com> <53EBA8FE dot 7070607 at redhat dot com>
On Wed, 2014-08-13 at 12:05 -0600, Jeff Law wrote:
> On 08/06/14 11:20, David Malcolm wrote:
> > gcc/
> > * debug.h (struct gcc_debug_hooks): Strengthen param 1 of hook
> > "label" from rtx to rtx_code_label *. Strengthen param 1 o
> > "var_location" hook from rtx to rtx_insn *.
> > (debug_nothing_rtx): Delete in favor of...
> > (debug_nothing_rtx_code_label): New prototype.
> > (debug_nothing_rtx_rtx): Delete unused prototype.
> > (debug_nothing_rtx_insn): New prototype.
> >
> > * final.c (final_scan_insn): Add checked cast to rtx_insn * when
> > invoking debug_hooks->var_location (in two places, one in a NOTE
> > case of a switch statement, the other guarded by a CALL_P
> > conditional. Add checked cast to rtx_code_label * when invoking
> > debug_hooks->label (within CODE_LABEL case of switch statement).
> >
> > * dbxout.c (dbx_debug_hooks): Update "label" hook from
> > debug_nothing_rtx to debug_nothing_rtx_code_label. Update
> > "var_location" from debug_nothing_rtx to debug_nothing_rtx_insn.
> > (xcoff_debug_hooks): Likewise.
> > * debug.c (do_nothing_debug_hooks): Likewise.
> > (debug_nothing_rtx): Delete in favor of...
> > (debug_nothing_rtx_insn): New function.
> > (debug_nothing_rtx_rtx): Delete unused function.
> > (debug_nothing_rtx_code_label): New function.
> > * dwarf2out.c (dwarf2_debug_hooks): Update "label" hook from
> > debug_nothing_rtx to debug_nothing_rtx_code_label.
> > (dwarf2out_var_location): Strengthen param "loc_note" from rtx
> > to rtx_insn *.
> > * sdbout.c (sdb_debug_hooks): Update "var_location" hook from
> > debug_nothing_rtx to debug_nothing_rtx_insn.
> > (sdbout_label): Strengthen param "insn" from rtx to
> > rtx_code_label *.
> > * vmsdbgout.c (vmsdbg_debug_hooks): Update "label" hook from
> > debug_nothing_rtx to debug_nothing_rtx_code_label. Update
> > "var_location" hook from debug_nothing_rtx to
> > debug_nothing_rtx_insn.
> OK. Note minor typo in changelog line #2. "o" at EOL should probably
> be "of"
Thanks. Bootstrapped; committed to trunk as r214259, with the ChangeLog
typo fixed.