This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 222/236] Use rtx_insn in more places in dwarf2cfi.c


On Tue, 2014-08-19 at 13:56 -0700, Richard Henderson wrote:
> On 08/06/2014 10:23 AM, David Malcolm wrote:
> >        else if (computed_jump_p (insn))
> >  	{
> >  	  for (rtx_expr_list *lab = forced_labels; lab; lab = lab->next ())
> > -	    maybe_record_trace_start (lab->element (), insn);
> > +	    maybe_record_trace_start (lab->insn (), insn);
> >  	}
> 
> I guess this is where #221 comes in.  Are there any other uses?

Some quick testing suggests that this is the only place, hence the fix
would seem to be to make forced_labels be an INSN_LIST rather than an
EXPR_LIST, and drop the insn method from rtx_expr_list.  I'll work on an
updated version of #222 that does this.

Thanks
Dave


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]