This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 025/236] make_insn_raw returns an rtx_insn
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 19 Aug 2014 15:35:34 -0400
- Subject: Re: [PATCH 025/236] make_insn_raw returns an rtx_insn
- Authentication-results: sourceware.org; auth=none
- References: <1407345815-14551-1-git-send-email-dmalcolm at redhat dot com> <1407345815-14551-26-git-send-email-dmalcolm at redhat dot com> <53EAE17A dot 9080900 at redhat dot com>
On Tue, 2014-08-12 at 21:54 -0600, Jeff Law wrote:
> On 08/06/14 11:20, David Malcolm wrote:
> > Doing so means strengthening the types of the make_raw callbacks within
> > emit-rtl.c from rtx to rtx_insn * as used by the emit_pattern_*
> > internal functions. There's more that could be done in terms of the
> > params to these functions, but we'll save that for later.
> >
> > gcc/
> > * rtl.h (make_insn_raw): Strengthen return type from rtx to
> > rtx_insn *.
> >
> > * emit-rtl.c (make_insn_raw): Strengthen return type and local
> > "insn" from rtx to rtx_insn *.
> > (make_debug_insn_raw): Strengthen return type from rtx to
> > rtx_insn *; strengthen local "insn" from rtx to rtx_debug_insn *.
> > (make_jump_insn_raw): Strengthen return type from rtx to
> > rtx_insn *; strengthen local "insn" from rtx to rtx_jump_insn *.
> > (make_call_insn_raw): Strengthen return type from rtx to
> > rtx_insn *; strengthen local "insn" from rtx to rtx_call_insn *.
> > (emit_pattern_before_noloc): Strengthen return type of "make_raw"
> > callback from rtx to rtx_insn *; likewise for local "insn" and
> > "next", adding a checked cast to rtx_insn in the relevant cases of
> > the switch statement.
> > (emit_pattern_after_noloc): Strengthen return type of "make_raw"
> > callback from rtx to rtx_insn *.
> > (emit_pattern_after_setloc): Likewise.
> > (emit_pattern_after): Likewise.
> > (emit_pattern_before_setloc): Likewise.
> > (emit_pattern_before): Likewise.
> OK.
Thanks. Committed to trunk as r214187.