This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add guality [p]type test.


On Tue, 2014-08-19 at 14:16 +0200, Richard Biener wrote:
> On Tue, Aug 19, 2014 at 2:10 PM, Mark Wielaard <mjw@redhat.com> wrote:
> > gcc/testsuite/ChangeLog
> > 2014-08-19  Mark Wielaard  <mjw@redhat.com>
> >
> >     * gcc.dg/guality/restrict.c: Add `used' attribute to all variables.
> >     (cpy): Change type of last argument to int.
> >
> > That last change is necessary to succeed with LTO. Otherwise the type of
> > the function:
> >
> > static __attribute__((noclone, noinline)) void *
> > cpy (void * restrict s1, const void * restrict s2, unsigned int n)
> >
> > comes out as:
> >
> > void *(void * restrict, const void * restrict, __unknown__)
> >
> > That seems a genuine bug. Should I commit the cpy function type change
> > to make the test PASS with LTO? Or leave it as is so it FAILs and
> > someone else can look into it?
> 
> Yeah, that's a genuine bug.  Not sure why it happens.  If you file a bug
> I can have a look later.

Filed as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62190 "LTO DWARF
produces __unknown__ type for unsigned int function argument type".

I included a smaller testcase in the bug that can just be dropped into
gcc/testsuite/gcc.dg/guality/ to show the issue. Shall I just commit the
change to the restrict.c testcase, so at least that one always PASSes
for now?

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]