This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C/C++ PATCH] Implement -Wbool-compare (PR c++/62153)


On 08/19/2014 12:52 PM, Marek Polacek wrote:
+  tree cst = TREE_CODE (op0) == INTEGER_CST
+	     ? op0 : TREE_CODE (op1) == INTEGER_CST ? op1 : NULL_TREE;

This indentation won't survive Emacs auto-indent; please add parentheses.

+      int sign = TREE_CODE (op0) == INTEGER_CST
+		 ? tree_int_cst_sgn (cst) : -tree_int_cst_sgn (cst);

Likewise.

OK with those fixed.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]