This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gomp4] Add tables generation
- From: Ilya Verbin <iverbin at gmail dot com>
- To: Bernd Schmidt <bernds at codesourcery dot com>
- Cc: Thomas Schwinge <thomas at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 19 Aug 2014 14:41:11 +0400
- Subject: Re: [gomp4] Add tables generation
- Authentication-results: sourceware.org; auth=none
- References: <20140327133129 dot GA1618 at msticlxl57 dot ims dot intel dot com> <20140327140218 dot GZ1817 at tucnak dot redhat dot com> <20140327161300 dot GA18191 at msticlxl57 dot ims dot intel dot com> <20140327161651 dot GC1817 at tucnak dot redhat dot com> <20140417183329 dot GA16810 at msticlxl57 dot ims dot intel dot com> <53970DA3 dot 20809 at codesourcery dot com> <20140610180658 dot GA27730 at msticlxl57 dot ims dot intel dot com> <20140813161914 dot GA26226 at msticlxl57 dot ims dot intel dot com> <20140818160759 dot GA60399 at msticlxl57 dot ims dot intel dot com> <53F228CD dot 70800 at codesourcery dot com>
On 18 Aug 18:24, Bernd Schmidt wrote:
> I think I'd be happier if the function was called init_offload_table
> and also collected functions, rather than leaving that to
> expand_omp_target. I think the patch would be ok with that change.
For the functions it's not so easy to identify which of them to add into the table, e.g.:
#pragma omp target
#pragma omp parallel
x++;
Here 2 functions with "omp declare target" attribute are created. But only the outer must be added to the table.
So I believe that expand_omp_target is better place for the functions.
-- Ilya