This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gomp4] Add tables generation

From: Bernd Schmidt <bernds at codesourcery dot com>
To: Ilya Verbin <iverbin at gmail dot com>
Cc: Thomas Schwinge <thomas at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 18 Aug 2014 18:24:45 +0200
Subject: Re: [gomp4] Add tables generation
Authentication-results: sourceware.org; auth=none
References: <532B1C45 dot 9020308 at codesourcery dot com> <20140327133129 dot GA1618 at msticlxl57 dot ims dot intel dot com> <20140327140218 dot GZ1817 at tucnak dot redhat dot com> <20140327161300 dot GA18191 at msticlxl57 dot ims dot intel dot com> <20140327161651 dot GC1817 at tucnak dot redhat dot com> <20140417183329 dot GA16810 at msticlxl57 dot ims dot intel dot com> <53970DA3 dot 20809 at codesourcery dot com> <20140610180658 dot GA27730 at msticlxl57 dot ims dot intel dot com> <20140813161914 dot GA26226 at msticlxl57 dot ims dot intel dot com> <20140818160759 dot GA60399 at msticlxl57 dot ims dot intel dot com>

On 08/18/2014 06:07 PM, Ilya Verbin wrote:

I discovered an issue in the LTO streaming out for target - currently any file (even without any pragma) compiled with -fopenmp/-fopenacc contains .gnu.target_lto_* sections.  This increases the size of an object file and makes lto-wrapper to run mkoffload.

Therefore, I propose to replace the condition before ipa_write_summaries:
- if (flag_openacc || flag_openmp)
+ if ((flag_openacc || flag_openmp) && !(vec_safe_is_empty (offload_funcs) && vec_safe_is_empty (offload_vars)))

But to do this, the offload_vars must be filled before the check (offload_funcs is already filled in expand_omp_target).
Here is the updated patch.  Bootstrap passed.  OK for gomp-4_0-branch?

I think I'd be happier if the function was called init_offload_table andalso collected functions, rather than leaving that to expand_omp_target.I think the patch would be ok with that change.



Bernd

Follow-Ups:
- Re: [gomp4] Add tables generation
  - From: Ilya Verbin

References:
- Re: [gomp4] Add tables generation
  - From: Ilya Verbin
- Re: [gomp4] Add tables generation
  - From: Ilya Verbin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]