This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite patch] add code to arm_thumbX_ok to exercise ABI


On 8 August 2014 02:30, Janis Johnson <janis_johnson@mentor.com> wrote:
> Running an arm-none-eabi test that adds "-mthumb" for a multilib that
> uses "-march=armv5te -mfloat-abi=hard" works fine if the test doesn't
> have any calls, but if it does then the effective-target checks for
> arm_thumb1_ok and arm_thumb2_ok pass but the test's compile step fails
> with "sorry, unimplemented: Thumb-1 hard-float VFP ABI".
>
> This patch adds code to those effective-target checks to exercise
> argument handling and causes them to fail for the multilib flags
> listed above.  Tested by running gcc.target/arm tests with a variety
> of multilib flags.  OK for mainline and the 4.9 branch?
>
> Janis

Some time ago (https://gcc.gnu.org/ml/gcc-patches/2012-09/msg01501.html)
I suggested to add similar stuff to check_effective_target_arm_arch_FUNC_ok
for similar reasons.

Do you agree?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]