This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM] Fix incorrect alignment of small values in minipool
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Thomas Preud'homme <Thomas dot Preudhomme at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 18 Aug 2014 11:34:06 +0100
- Subject: Re: [PATCH, ARM] Fix incorrect alignment of small values in minipool
- Authentication-results: sourceware.org; auth=none
- References: <000501cfb538$bedfae80$3c9f0b80$ at arm dot com> <53E8849E dot 4010200 at arm dot com> <000001cfb6cb$188e29a0$49aa7ce0$ at arm dot com>
On 13/08/14 08:49, Thomas Preud'homme wrote:
>> From: Richard Earnshaw
>> Sent: Monday, August 11, 2014 4:54 PM
>>
>> I think this is the wrong place for this sort of fix up. HFmode values
>> are fixed up in the consttable_4 pattern and it looks wrong to be that
>> HImode values are then fixed up in a different place. We should be
>> consistent and do all the fix ups in one location.
>
> Sorry for the delay in answering.
>
> The problem is that in the pattern for constable_4 we don't have the information
> about the access mode for this entry. In the testcase along this patch the rtx
> manipulated in the pattern is VOIDmode while the access mode is HImode. In
> dump_minipool on the other hand the information can be found in mp->mode.
>
I think it would be better to make sure the mode field never contains
VOIDmode. That's not really useful information.
R.