This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[jbglaw at lug-owl dot de: Re: r214024 - in /trunk/gcc: ChangeLog c-family/Cha...]


Hi!

Wrongly replied to the CVS list. Maybe we'd have a reply-to header
there?

MfG, JBG

----- Forwarded message from Jan-Benedict Glaw <jbglaw@lug-owl.de> -----

Date: Sat, 16 Aug 2014 15:50:41 +0200
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: manu@gcc.gnu.org
Cc: gcc-cvs@gcc.gnu.org
Subject: Re: r214024 - in /trunk/gcc: ChangeLog c-family/Cha...
X-Operating-System: Linux mail 3.2.0-4-686-pae
User-Agent: Mutt/1.5.21 (2010-09-15)

Hi Manuel,

On Fri, 2014-08-15 15:10:16 -0000, manu@gcc.gnu.org <manu@gcc.gnu.org> wrote:
> URL: https://gcc.gnu.org/viewcvs?rev=214024&root=gcc&view=rev
> 2014-08-15  Manuel LÃpez-IbÃÃez  <manu@gcc.gnu.org>
> 
> 	PR fortran/44054
> gcc/
> 	* diagnostic.c (build_message_string): Make it extern.
> 	* diagnostic.h (build_message_string): Make it extern.
> c-family/
> 	* c-format.c: Handle Fortran flags.
> fortran/
> 	* gfortran.h: Define GCC_DIAG_STYLE.
> 	(gfc_diagnostics_init,gfc_warning_cmdline): Declare.
> 	* trans-array.c: Include gfortran.h before diagnostic-core.h.
> 	* trans-expr.c: Likewise.
> 	* trans-openmp.c: Likewise.
> 	* trans-const.c: Likewise.
> 	* trans.c: Likewise.
> 	* trans-types.c: Likewise.
> 	* f95-lang.c: Likewise.
> 	* trans-decl.c: Likewise.
> 	* trans-io.c: Likewise.
> 	* trans-intrinsic.c: Likewise.
> 	* error.c: Include diagnostic.h and diagnostic-color.h.
> 	(gfc_diagnostic_build_prefix): New.
> 	(gfc_diagnostic_starter): New.
> 	(gfc_diagnostic_finalizer): New.
> 	(gfc_warning_cmdline): New.
> 	(gfc_diagnostics_init): New.
> 	* gfc-diagnostic.def: New.
> 	* options.c (gfc_init_options): Call gfc_diagnostics_init.
> 	(gfc_post_options): Use gfc_warning_cmdline.

I think that this breaks fortran all over, caught by my build robots,
see eg.
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=327937:

g++ -c  -DIN_GCC_FRONTEND -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common  -DHAVE_CONFIG_H -I. -Ifortran -I../../../gcc/gcc -I../../../gcc/gcc/fortran -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include  -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../gcc/gcc/../libbacktrace    -o fortran/options.o -MT fortran/options.o -MMD -MP -MF fortran/.deps/options.TPo ../../../gcc/gcc/fortran/options.c
../../../gcc/gcc/fortran/options.c: In function âbool gfc_post_options(const char**)â:
../../../gcc/gcc/fortran/options.c:357:55: error: unknown conversion type character âqâ in format [-Werror=format=]
           (filename[0] == '\0') ? "<stdin>" : filename);
                                                       ^
../../../gcc/gcc/fortran/options.c:357:55: error: too many arguments for format [-Werror=format-extra-args]
../../../gcc/gcc/fortran/options.c:367:23: error: unknown conversion type character â<â in format [-Werror=format=]
         "in free form");
                       ^
../../../gcc/gcc/fortran/options.c:367:23: error: unknown conversion type character â>â in format [-Werror=format=]
../../../gcc/gcc/fortran/options.c:369:73: error: unknown conversion type character â<â in format [-Werror=format=]
  gfc_warning_cmdline ("%<-fd-lines-as-code%> has no effect in free form");
                                                                         ^
../../../gcc/gcc/fortran/options.c:369:73: error: unknown conversion type character â>â in format [-Werror=format=]
../../../gcc/gcc/fortran/options.c:388:39: error: unknown conversion type character â<â in format [-Werror=format=]
     gfc_option.flag_max_stack_var_size);
                                       ^
../../../gcc/gcc/fortran/options.c:388:39: error: unknown conversion type character â>â in format [-Werror=format=]
../../../gcc/gcc/fortran/options.c:388:39: error: unknown conversion type character â<â in format [-Werror=format=]
../../../gcc/gcc/fortran/options.c:388:39: error: unknown conversion type character â>â in format [-Werror=format=]
../../../gcc/gcc/fortran/options.c:390:78: error: unknown conversion type character â<â in format [-Werror=format=]
     gfc_warning_cmdline ("Flag %<-fno-automatic%> overwrites %<-frecursive%>");
                                                                              ^
../../../gcc/gcc/fortran/options.c:390:78: error: unknown conversion type character â>â in format [-Werror=format=]
../../../gcc/gcc/fortran/options.c:390:78: error: unknown conversion type character â<â in format [-Werror=format=]
[...]


Seems %q et al isn't wired up properly, like for the other functions
containing our conversion characters?

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of: 17:45 <@Eimann> Hrm, das E90 hat keinen Lebenszeit Call-Time Counter mehr
the second  : 17:46 <@jbglaw> Eimann: WofÃr braucht man das?
              17:46 <@jbglaw> Eimann: FÃr mich ist an 'nem Handy wichtig, daà ich mein
                              GegeÃber hÃren kann. Und daà mein GegenÃber mich versteht...
              17:47 <@KrisK> jbglaw: was du meinst ist wodka.
              17:47 <@KrisK> jbglaw: es klingelt und man hÃrt stimmen



----- End forwarded message -----

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
 Signature of:                    Arroganz verkÃrzt fruchtlose GesprÃche.
 the second  :                                   -- Jan-Benedict Glaw

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]