This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH GCC]Add 'force-dwarf-lexical-blocks' command line option


On Mon, 28 Jul 2014, Herman, Andrei wrote:

> Please find attached the fixed patch files for this change:
> 	1. Add command line option -fforce-dwarf-lexical-blocks.
> 	2. Support flag_force_dwarf_blocks in C.

The front-end parts of these patches are OK with the changes indicated 
below if the non-front-end parts are approved.

> +  /* The -fforce-dwarf-lexical-blocks option is only relevant when debug
> +     info is in DWARF4 format.  */
> +  if (flag_force_dwarf_blocks)
> +    {
> +      if (write_symbols != DWARF2_DEBUG)
> +        flag_force_dwarf_blocks = 0;
> +      if (write_symbols == DWARF2_DEBUG && dwarf_version < 4)
> +        {
> +          inform (input_location,
> +                  "-fforce-dwarf-lexical-blocks is only supported with "
> +                  "DWARF4 debug format");
> +          flag_force_dwarf_blocks = 0;
> +        }
> +    }

If it's deliberate not to give the diagnostic for write_symbols != 
DWARF2_DEBUG, please add a comment explaining why the diagnostic is not 
given in that case.

> +fforce-dwarf-lexical-blocks
> +C C++ Var(flag_force_dwarf_blocks)
> +Force generation of lexical blocks in DWARF output

As previously noted, should also be enabled for ObjC and ObjC++ unless 
there is a clear reason not to do so.

> +/* Information about a statement list created for a label (is_label=true)
> +   or for a forced c99 scope.  The -fforce-dwarf-lexical-blocks will

"The -fforce-dwarf-lexical-blocks option".

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]