This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Felix Yang <fei dot yang0953 at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Ian Lance Taylor <ian at airs dot com>, dj at redhat dot com, vmakarov at redhat dot com
- Date: Wed, 13 Aug 2014 14:55:45 +0200
- Subject: Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent
- Authentication-results: sourceware.org; auth=none
- References: <CAFc0fxx7V6o-d0adJfbQ7=+zXFTu8Ebh0sY9oPJP0L8xrJ6oEA at mail dot gmail dot com> <20140813121643 dot GT1784 at tucnak dot redhat dot com> <CAFc0fxwCYiMbR9HBizRTA5y7uXGL+vz2JF-35Li6a_usDc5dRA at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Aug 13, 2014 at 08:48:52PM +0800, Felix Yang wrote:
> I did tried to use the glibc qsort. I compared the source of the
> two versions.
> I found that the BSD one is more self-contained and easy for
> integration with libiberty.
Being more self-contained is not what we care about, the most significant
thing about qsort from GCC POV is performance, people complain about compile
times and slowing compilation down by a few % just so that libiberty can
contain a single file rather than two files doesn't look to be a good idea.