This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH mips] Do not compile mips16.S in soft-float mode
- From: Eric Christopher <echristo at gmail dot com>
- To: Steve Ellcey <sellcey at mips dot com>
- Cc: "Moore, Catherine" <Catherine_Moore at mentor dot com>, "matthew dot fortune at imgtec dot com" <matthew dot fortune at imgtec dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 12 Aug 2014 11:03:55 -0700
- Subject: Re: [PATCH mips] Do not compile mips16.S in soft-float mode
- Authentication-results: sourceware.org; auth=none
- References: <fc2dac93-a7ca-4601-aa38-c25dd3e4233b at BAMAIL02 dot ba dot imgtec dot org> <FD3DCEAC5B03E9408544A1E416F11242015A689FD7 at NA-MBX-04 dot mgc dot mentorg dot com> <CALehDX4O0Tk7N981UNWPQ0HmLetTo1rkJ2zac=9h40CxS_KWPw at mail dot gmail dot com> <1407857590 dot 2601 dot 66 dot camel at ubuntu-sellcey>
Thanks!
-eric
On Tue, Aug 12, 2014 at 8:33 AM, Steve Ellcey <sellcey@mips.com> wrote:
> On Tue, 2014-08-12 at 00:07 -0700, Eric Christopher wrote:
>> >>
>> >> -#ifdef __mips_micromips
>> >> +#if defined(__mips_micromips) || defined(__mips_soft_float)
>> >> /* DO NOTHING */
>> >> #else
>> >>
>>
>> Mind adding a comment here explaining why we don't want to do anything
>> for soft float (and micromips)?
>>
>> OK otherwise.
>>
>> Thanks!
>>
>> -eric
>
> OK, I added this comment to the checkin:
>
> #if defined(__mips_micromips) || defined(__mips_soft_float)
> /* Do nothing because this code is only needed when linking
> against mips16 hard-float objects. Neither micromips code
> nor soft-float code can be linked against mips16 hard-float
> objects so we do not need these routines when building libgcc
> for those cases. */
>
>
> Steve Ellcey
> sellcey@mips.com
>
>