This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH powerpc64] Add a new constraint to insn movdi_internal64


On Fri, Aug 8, 2014 at 1:50 PM, Carrot Wei <carrot@google.com> wrote:
> Thank you for the comment, I've updated the patch.
>
> OK for trunk and 4.9 branch?
>
>
> 2014-08-08  Guozhi Wei  <carrot@google.com>
>
>         * config/rs6000/rs6000.md (*movdi_internal64): Add a new constraint.
>
>
> On Wed, Aug 6, 2014 at 7:28 PM, Segher Boessenkool
> <segher@kernel.crashing.org> wrote:
>> On Wed, Aug 06, 2014 at 04:48:26PM -0700, Carrot Wei wrote:
>>> -   mtvsrd %x0,%1"
>>> -  [(set_attr "type" "store,load,*,*,*,*,fpstore,fpload,fp,mfjmpr,mtjmpr,*,mftgpr,mffgpr,mftgpr,mffgpr")
>>> -   (set_attr "length" "4,4,4,4,4,20,4,4,4,4,4,4,4,4,4,4")])
>>> +   mtvsrd %x0,%1
>>> +   xxlxor %x0,%x0"
>>> +  [(set_attr "type" "store,load,*,*,*,*,fpstore,fpload,fp,mfjmpr,mtjmpr,*,mftgpr,mffgpr,mftgpr,mffgpr,*")
>>> +   (set_attr "length" "4,4,4,4,4,20,4,4,4,4,4,4,4,4,4,4,4")])
>>
>>
>> "type" should be "vecsimple" for xxlxor, not "integer".

xxlxor requires three operands, not two:

xxlxor %x0,%x0,%x0

Okay with that change.

Thanks, David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]