This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][committed] Remove arm-specific -march option in gcc.dg/pr61756.c
- From: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 08 Aug 2014 11:46:47 +0100
- Subject: Re: [PATCH][committed] Remove arm-specific -march option in gcc.dg/pr61756.c
- Authentication-results: sourceware.org; auth=none
- References: <53E33CF3 dot 8090605 at arm dot com> <53E4AA0C dot 4000908 at arm dot com>
On 07/08/14 09:46, Kyrill Tkachov wrote:
Hi all,
As Bin pointed out, setting -march=armv5 explicitly on this test causing a FAIL when testing with /-mthumb.
The bug fixed by the commit that added this test occured only on pre-SMP architectures, i.e. ARMv5 and earlier.
I think it's best to just remove the -march option. If someone was hit by PR 61756 due to testing ARMv5 CPUs and we regress on this issue they will still catch it, while forcing -march=armv5 here only causes multilib testing headaches.
Committed as obvious with r213701.
Thanks,
Kyrill
Now with patch attached. Sorry for the noise.
Kyrill
2014-08-07 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* gcc.dg/pr61756.c: Remove arm-specific dg-options.
Index: gcc/testsuite/gcc.dg/pr61756.c
===================================================================
--- gcc/testsuite/gcc.dg/pr61756.c (revision 213700)
+++ gcc/testsuite/gcc.dg/pr61756.c (working copy)
@@ -2,7 +2,6 @@
/* { dg-do compile } */
/* { dg-options "-O2" } */
-/* { dg-options "-O2 -march=armv5" { target arm*-*-* } } */
#include <stdatomic.h>